This repository has been archived by the owner on Sep 16, 2024. It is now read-only.
fix: Fix zeros being loaded instead of fert names #321
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Simple ammend to the loading ticket, parseInt was missing a radix which husky caught and stopped the commit from being pushed. Didn't notice it wasn't added before merging, resulting in this quick pr 😄
The fix is for zeros being loaded in place of fertilizer names. To fix it I simplified the code I realised was overcomplicated and not working properly. It required a fallback since it was using a find(), which could return undefined. The fallback was zero. Now there's no need for it since fertilizers were updated to match nmp id's, making it easier to assign their names according to their id's.
Type of changes
Please delete options that are not relevant.
Checklist
Further comments
Thanks for the PR!
Deployments, as required, will be available below:
Please create PRs in draft mode. Mark as ready to enable:
After merge, new images are deployed in: