Skip to content
This repository has been archived by the owner on Sep 16, 2024. It is now read-only.

chore: Enhance Next button behaviour #324

Merged
merged 3 commits into from
Aug 5, 2024
Merged

Conversation

GDamaso
Copy link
Contributor

@GDamaso GDamaso commented Aug 5, 2024

Description

Straightoforward changes that fix weird Next button behaivour.

Describe the Bug

Clicking on the next button moves the form forward no matter the condition.

Expected Behaviour

Clicking the next button closes the current form and opens the next one. If the next button is clicked on a previously filled out form, it only updates the data and closes it's form section, which is different then a forward movement in the forms.

If the user is working on form section 3 and he clicks on the next button on the form section 1, section 3 would close and open section 4.

Actual Behaviour

If the user is working on form section 3 and he clicks on the next button on the form section 1, section 3 is not affected and section 1 closes.

Type of changes

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

  • I have read the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have already been accepted and merged

Further comments


Thanks for the PR!

Deployments, as required, will be available below:

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are deployed in:

@GDamaso GDamaso linked an issue Aug 5, 2024 that may be closed by this pull request
3 tasks
Copy link
Contributor

@kcaparas1630 kcaparas1630 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great, bug is not there anymore.

@GDamaso GDamaso enabled auto-merge (squash) August 5, 2024 17:50
@GDamaso GDamaso merged commit 9b2130d into main Aug 5, 2024
15 checks passed
@GDamaso GDamaso deleted the BB-322-fix-next-button-behaviour branch August 5, 2024 17:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix Next Button behaviour
2 participants