This repository has been archived by the owner on Sep 16, 2024. It is now read-only.
generated from bcgov/quickstart-openshift
-
Notifications
You must be signed in to change notification settings - Fork 2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kcaparas1630
requested review from
DerekRoberts,
dallascrichmond,
LocalNewsTV,
acatchpole,
fergmac,
Shakespeares-spy and
GDamaso
as code owners
August 9, 2024 20:07
Closed
2 tasks
GDamaso
reviewed
Aug 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job!
I think we should improve something before merging though.
When you click the date picker, it only works if you click exactly on the calendar icon. Could you fix this? I think it's important.
Also, it would be better to display the month and year instead of month and day so it matches nmp. The day really doesn't matter that much.
Thanks for the work!
frontend/src/Commons/Forms/InputModules/CalculateNutrients/CalculateNutrientsList.tsx
Outdated
Show resolved
Hide resolved
frontend/src/Commons/Forms/InputModules/FieldsAndSoil/FieldsListComponent.tsx
Outdated
Show resolved
Hide resolved
frontend/src/Commons/Forms/InputModules/CalculateNutrients/CalculateNutrients.tsx
Show resolved
Hide resolved
…ne-2024 into BB-333-implement-datepickers
GDamaso
approved these changes
Aug 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job man!
🚀
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implemented Date Pickers and converted it as ISOString, as NMP is using ISOString for their date pickers. For the list, I've narrowed it down and only took Month and day on a default en-us locale.
Note
You'll notice a quite misalign on the the information buttons in Fields Module. I will fix that on the next styling ticket. Or it might get fixed when the other pr is merged.
Better Berries
NMP
Type of changes
Please delete options that are not relevant.
Checklist
Further comments
Thanks for the PR!
Deployments, as required, will be available below:
Please create PRs in draft mode. Mark as ready to enable:
After merge, new images are deployed in: