Skip to content
This repository has been archived by the owner on Sep 16, 2024. It is now read-only.

feat: [BB-333] implement datepickers #342

Merged
merged 9 commits into from
Aug 10, 2024
Merged

Conversation

kcaparas1630
Copy link
Contributor

@kcaparas1630 kcaparas1630 commented Aug 9, 2024

Description

Implemented Date Pickers and converted it as ISOString, as NMP is using ISOString for their date pickers. For the list, I've narrowed it down and only took Month and day on a default en-us locale.

Note

You'll notice a quite misalign on the the information buttons in Fields Module. I will fix that on the next styling ticket. Or it might get fixed when the other pr is merged.

Better Berries

image

NMP

samplingMonthNMP

Type of changes

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

  • I have read the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have already been accepted and merged

Further comments


Thanks for the PR!

Deployments, as required, will be available below:

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are deployed in:

@kcaparas1630 kcaparas1630 linked an issue Aug 9, 2024 that may be closed by this pull request
2 tasks
Copy link
Contributor

@GDamaso GDamaso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!
I think we should improve something before merging though.
When you click the date picker, it only works if you click exactly on the calendar icon. Could you fix this? I think it's important.
Also, it would be better to display the month and year instead of month and day so it matches nmp. The day really doesn't matter that much.

Thanks for the work!

Copy link
Contributor

@GDamaso GDamaso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job man!
🚀

@kcaparas1630 kcaparas1630 merged commit f52d505 into main Aug 10, 2024
15 checks passed
@kcaparas1630 kcaparas1630 deleted the BB-333-implement-datepickers branch August 10, 2024 01:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement DatePickers
2 participants