This repository has been archived by the owner on Sep 16, 2024. It is now read-only.
generated from bcgov/quickstart-openshift
-
Notifications
You must be signed in to change notification settings - Fork 2
feat: Bb 254 implement edit and delete fields and crops buttons #350
Merged
GDamaso
merged 17 commits into
main
from
BB-254-implement-edit-and-delete-fields-and-crops-buttons
Aug 14, 2024
Merged
feat: Bb 254 implement edit and delete fields and crops buttons #350
GDamaso
merged 17 commits into
main
from
BB-254-implement-edit-and-delete-fields-and-crops-buttons
Aug 14, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
GDamaso
force-pushed
the
BB-254-implement-edit-and-delete-fields-and-crops-buttons
branch
from
August 14, 2024 02:33
65339a3
to
ede6a6e
Compare
GDamaso
force-pushed
the
BB-254-implement-edit-and-delete-fields-and-crops-buttons
branch
from
August 14, 2024 03:09
5a53ac2
to
2a187c5
Compare
GDamaso
commented
Aug 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🆗
GDamaso
requested review from
DerekRoberts,
dallascrichmond,
LocalNewsTV,
acatchpole,
fergmac,
kcaparas1630 and
Shakespeares-spy
as code owners
August 14, 2024 04:32
kcaparas1630
approved these changes
Aug 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is good enough for now. Great Job!
GDamaso
deleted the
BB-254-implement-edit-and-delete-fields-and-crops-buttons
branch
August 14, 2024 16:18
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The field Edit button actually delets the field and populates the form with it's data. This was the best behaviour I could get out of it within our time constraints.
Type of changes
Please delete options that are not relevant.
Checklist
Further comments
Thanks for the PR!
Deployments, as required, will be available below:
Please create PRs in draft mode. Mark as ready to enable:
After merge, new images are deployed in: