-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SBCQ180_Sonar_Reliability #994
SBCQ180_Sonar_Reliability #994
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sonarcloud is complaining about the while loop doing only 1 iteration. The code now does do 3 tries but we already do that through Cypress config file. Maybe it should be a if condition?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That sounds good @josekudiyirippil. Since we are just catching, logging, and re-throwing the exception in the original code we don't even need an if
statement, just keep the try/catch
and remove the while(true)
loop.
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good
Sonar: Issue: Reliability : Refactor this loop to do more than one iteration.
Description
files affecetd :
appointment-frontend/cypress/plugins/index.ts