Suppress logging of repeating errors when retrying automatically #1013
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Retrying on an error that is not permanent but may last for a long time, for hundreds or even thousands of attempts (for example, connection refused, one of the roots not mounted), it is unnecessary to spam the log with the same error every time.
gdt
added
the
discuss
|
retry mode is complicated and has a lot of issues. For now, I have decided that I don't want to suppress errors, and that instead people who are concerned about too many errors in the log should instead reduce the rate of errors happening. This may well take a great deal of stepping back and reconsidering many things, but that's ok with me. |
|
I agree, this PR no longer makes sense. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch improves the logging in case of automatic retry in repeat mode, which is one of the issues pointed out in #996.
Repeating messages are suppressed only in the log, not on stdout when run interactively.
Easiest reviewed commit by commit.