Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: moving away from juniper and sea-orm #88

Merged
merged 8 commits into from
Dec 13, 2023
Merged

feat: moving away from juniper and sea-orm #88

merged 8 commits into from
Dec 13, 2023

Conversation

sargon64
Copy link
Contributor

@sargon64 sargon64 commented Dec 11, 2023

PR to move away from both juniper and sea-orm.

Juniper has been a thorn in my side for quite a while due to it lagging behind in features that asnyc-graphql now provides. It's a similar story with seaORM, where I feel like I'm trying to fight with the ORM to do things that I can do easily in SQL.

And so, I finally decided to bite the bullet and start switching.

I'd like to finish this before trying to resolve [nolink] #85 & #86 as migrating would help with adding those tremendously.

Checklist:

  • Switch from juniper to async-graphql
    • Switch from actix-web to poem (the docs for async-graphql-actix seem to be out of date, and don't work + poem seems to be the more supported framework)
  • Switch from SeaORM to sqlx
    • Add a migration system for meilisearch (as of right now we've been piggybacking off of seaorm's migraiton system for changes to meili, but It's time to find a diffrent soultion)

@sargon64 sargon64 changed the title feat: async-graphql with poem migraiton Moving away from juniper and sea-orm Dec 11, 2023
@sargon64 sargon64 changed the title Moving away from juniper and sea-orm feat: moving away from juniper and sea-orm Dec 13, 2023
@sargon64 sargon64 requested a review from rithik-b December 13, 2023 02:15
@sargon64 sargon64 marked this pull request as ready for review December 13, 2023 02:15
@sargon64 sargon64 merged commit b6f30d1 into main Dec 13, 2023
2 checks passed
Copy link

@rithik-b rithik-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm (I'm a 10x rust dev btw)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants