Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update some stats package functions to fix org.bioconductor:affy #269

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

psolaimani
Copy link
Contributor

GNU R version 3.3.1

@akbertram
Copy link
Member

@psolaimani is this still relevant?

@psolaimani
Copy link
Contributor Author

psolaimani commented Feb 22, 2017

the problem was that some packages were failing due to difference in optim function which has been manually implemented in java and probably has changed since in GNU R. The goal was to get the C optim code transpiled like we did with C code in packages. But this came to halt when I learned that transpiling C code of core functions is not similar to what happen with packages.

SETCADR and related functions are in the meantime implemented, so this can be removed.

.External2 was used somewhere in functions that use optim and still needs to be implemented.

I'm not sure if transpiling optim was a good idea from the begining. I think we can better update the current implementation to match the current GNU R version in its formals and return.

@akbertram
Copy link
Member

What do you mean by

transpiling C code of core functions is not similar to what happen with packages.

?

Parham Solaimani added 3 commits February 24, 2017 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants