Feature/large primitive arrays

gradle.properties

@@ -1 +1,2 @@
 org.gradle.parallel=true
+org.gradle.jvmargs='-Dfile.encoding=UTF-8'

tools/gcc-bridge/compiler/src/main/java/org/renjin/gcc/codegen/array/ArrayTypeStrategy.java

@@ -31,7 +31,6 @@
 import org.renjin.gcc.codegen.vptr.VPtrStrategy;
 import org.renjin.gcc.gimple.GimpleVarDecl;
 import org.renjin.gcc.gimple.expr.GimpleConstructor;
-import org.renjin.gcc.gimple.expr.GimpleIntegerConstant;
 import org.renjin.gcc.gimple.type.GimpleArrayType;
 import org.renjin.repackaged.asm.Type;
 import org.renjin.repackaged.guava.base.Preconditions;
@@ -172,25 +171,13 @@ public FatArrayExpr constructorExpr(ExprFactory exprFactory, MethodGenerator mv,
   }
 
   private void addElementConstructors(List<JExpr> values, ExprFactory exprFactory, GimpleConstructor constructor) {
-    int index = 0;
-    for (GimpleConstructor.Element element : constructor.getElements()) {
+    for (GimpleConstructor.Element element : constructor.normalizeArrayElements()) {
 
-      if(element.getField() instanceof GimpleIntegerConstant) {
-        int elementIndex = ((GimpleIntegerConstant) element.getField()).getValue().intValue();
-        if(elementIndex < index) {
-          throw new IllegalStateException("index = " + index + ", elementIndex = " + elementIndex);
+      if(element == null) {
+        for (int i = 0; i < elementValueFunction.getElementLength(); ++i) {
+          values.add(null);
         }
-        // Some arrays have jagged initialization (looking at you, Fortran!)
-        // so we may need to skip a few elements
-        while(index < elementIndex) {
-          for(int i = 0; i < elementValueFunction.getElementLength(); ++i) {
-            values.add(null);
-          }
-          index++;
-        }
-      }
-
-      if(element.getValue() instanceof GimpleConstructor &&
+      } else if(element.getValue() instanceof GimpleConstructor &&
           element.getValue().getType() instanceof GimpleArrayType) {
         GimpleConstructor elementConstructor = (GimpleConstructor) element.getValue();
 
@@ -201,7 +188,6 @@ private void addElementConstructors(List<JExpr> values, ExprFactory exprFactory,
         List<JExpr> arrayValues = elementValueFunction.toArrayValues(elementExpr);
         values.addAll(arrayValues);
       }
-      index++;
     }
   }
 

tools/gcc-bridge/compiler/src/main/java/org/renjin/gcc/codegen/constructors/ConstructorFactory.java

@@ -0,0 +1,34 @@
+package org.renjin.gcc.codegen.constructors;
+
+import org.renjin.gcc.codegen.MethodGenerator;
+import org.renjin.gcc.codegen.ResourceWriter;
+import org.renjin.gcc.codegen.expr.GExpr;
+import org.renjin.gcc.gimple.expr.GimpleConstructor;
+
+import static org.renjin.gcc.codegen.constructors.Constructors.*;
+
+public class ConstructorFactory {
+  public static GExpr tryCreate(MethodGenerator mv, ResourceWriter resourceWriter, GimpleConstructor value) {
+    for (ConstructorInterface instance : instances) {
+      GExpr result = instance.tryCreate(mv, resourceWriter, value);
+      if (result != null) {
+        return result;
+      }
+    }
+    return null;
+  }
+
+  private static Constructors.ConstructorInterface[] instances = {
+      // mitigate `Method code too large` errors for large constant array expressions
+      largeShortArray,
+      largeIntArray,
+      largeLongArray,
+      largeFloatArray,
+      largeDoubleArray,
+      // store large string arrays either in the string pool, or in a resource for very large arrays
+      stringArray,
+      // store char arrays as a string in the constant pool
+      charArray, // n.b., this should be _after_ `largeShortArray`
+      Constructors::int32Array2d
+  };
+}