Add "horizontal" and "vertical" aliases for align_items and justify_content #3113
Conversation
|
I'll look at the MicroPython failure tomorrow, but any other review comments would be useful. |
There was a problem hiding this comment.
The implementation of the aliasing behavior makes sense; a couple of minor notes inline.
However, reading how this is documented (in the changenote and the docs for Pack), I've got some pedagogical concerns about this change. See #3113 for further discussion.
| try: | ||
| _all_properties = style_cls._BASE_ALL_PROPERTIES | ||
| except AttributeError: | ||
| # Travertino 0.3 compatibility | ||
| _all_properties = style_cls._ALL_PROPERTIES |
There was a problem hiding this comment.
It looks like MicroPython doesn't support the __init_subclass__ method used by BaseStyle, so this will have to be revisited once we start actually running Travertino on MicroPython rather than simply importing it.
There was a problem hiding this comment.
Actually turns out it's super simple, I can just replace the subclass_init with a pair of properties.
Co-authored-by: Russell Keith-Magee <[email protected]>
There was a problem hiding this comment.
After the clarifications in the discussion on #3111, I think this is now good to go.
PR Checklist: