Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: web.archive.org bugs #22

Merged
merged 5 commits into from
Jan 10, 2024
Merged

fix: web.archive.org bugs #22

merged 5 commits into from
Jan 10, 2024

Conversation

kishore881
Copy link
Contributor

@kishore881 kishore881 commented Jan 8, 2024 •
edited
Loading

fix for Issue #22 , #23

after fix:
Screenshot 2024-01-08 at 8 53 11 PM

@kishore881 kishore881 changed the title fix: treat timestamps on web.archive.org as UTC fix: web.archive.org bugs Jan 9, 2024
msramalho
msramalho approved these changes Jan 10, 2024
View reviewed changes
Copy link
Contributor

@msramalho msramalho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

really great addition with the Observer pattern, not to mention the detection and fix of the timezone.

@msramalho msramalho merged commit e9dc66e into bellingcat:main Jan 10, 2024
2 checks passed
@msramalho
Copy link
Contributor

deployed, should be up in the next day.

@kishore881 kishore881 deleted the fix/utc_web_archive branch January 10, 2024 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msramalho msramalho msramalho approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kishore881 @msramalho