Why is a CameraIntrinsicTransform a FrameTransform? It's not an affin…

…e transformation, right?
benjamindkilleen · Feb 17, 2024 · 2739296 · 2739296
1 parent 3afb363
commit 2739296
Showing 1 changed file with 7 additions and 7 deletions.
diff --git a/src/killeengeo/core.py b/src/killeengeo/core.py
@@ -1161,20 +1161,20 @@ def check_dim():
             # bulky.
             return [self @ x for x in other]
         elif isinstance(self, FrameTransform):
-            if isinstance(other, FrameTransform):
+            if isinstance(other, CameraIntrinsicTransform):
+                return CameraIntrinsicTransform(
+                    self.data @ other.data, other._sensor_height, other._sensor_width
+                )
+            elif isinstance(other, CameraProjection):
+                return CameraProjection(self @ other.intrinsic, other.extrinsic.copy())
+            elif isinstance(other, FrameTransform):
                 return FrameTransform(self.data @ other.data)
             elif isinstance(other, HasLocationAndDirection):
                 p = other.get_point()
                 v = other.get_direction()
                 p_ = self @ p
                 v_ = self @ v
                 return type(other).from_point_direction(p_, v_)
-            elif isinstance(other, CameraIntrinsicTransform):
-                return CameraIntrinsicTransform(
-                    self.data @ other.data, other._sensor_height, other._sensor_width
-                )
-            elif isinstance(other, CameraProjection):
-                return CameraProjection(self @ other.intrinsic, other.extrinsic.copy())
             elif isinstance(other, Primitive):
                 # Catches other primitives, which are parameterized by columns of points or vectors.
                 return type(other)(self.data @ other.data)