refactor(init-cli): Refactor the Init CLI command to be callable from runtime #2468
+80
−65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2468 +/- ##
===========================================
- Coverage 32.36% 21.17% -11.20%
===========================================
Files 350 3 -347
Lines 15592 85 -15507
Branches 20 20
===========================================
- Hits 5047 18 -5029
+ Misses 10182 66 -10116
+ Partials 363 1 -362 |
rezbera
commented
Feb 3, 2025
| @@ -125,7 +124,7 @@ func InitCmd(mm interface { | |||
| if config.RootDir == "" { | |||
| config.RootDir = clientCtx.HomeDir | |||
| } | |||
|
|
|||
| config.Moniker = args[0] | |||
There was a problem hiding this comment.
Reordered setting the moniker so its closer to where other config updates are done
rezbera
commented
Feb 3, 2025
Comment on lines
-158
to
-161
| nodeID, _, err := genutil.InitializeNodeValidatorFilesFromMnemonic(config, mnemonic, consensusKeyAlgo) | ||
| if err != nil { | ||
| return err | ||
| } |
There was a problem hiding this comment.
Moved this core logic to Init
rezbera
commented
Feb 3, 2025
| func InitCmd(mm interface { | ||
| DefaultGenesis() map[string]json.RawMessage | ||
| ValidateGenesis(genesisData map[string]json.RawMessage) error |
There was a problem hiding this comment.
We run ValidateGenesis in initChain and hence we don't use it here (i.e. this was unused)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.