fix(noncer): initialize nonce before main txr loop

[calbera]

Also adds a crucial timeout to avoid network call holding lock forever

Summary by CodeRabbit

• Refactor
  • Improved the nonce tracking mechanism to enhance transaction processing efficiency.
• Documentation
  • Updated comments in core/transactor/config.go for clarity.

[coderabbitai]

Warning

Rate Limit Exceeded

@calbera has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 15 minutes and 30 seconds before requesting another review.

How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.
Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.
Please see our FAQ for further information.

Commits

Files that changed from the base of the PR and between c1794a8 and 46665fa.

Walkthrough

The recent update brings proactive changes to the Noncer type's nonce management and enhances the reliability of the Acquire method by introducing a timeout-controlled context for network requests. These changes aim to improve resource management and the overall control flow within the Noncer type's methods.

Changes

File Path	Change Summary
.../tracker/noncer.go	- Modified RefreshLoop to call refreshConfirmedNonce before the timer loop - Implemented timeout context in Acquire method with context cancellation
core/transactor/config.go	- Removed period at the end of a comment for the EmtpyQueueDelay field
core/transactor/transactor.go	- Changed awsMaxBatchSize constant to inflightChanSize - Updated method signature for SubscribeTxResults in TxrV2
types/queue/sqs/sqs.go	- Introduced awsMaxBatchSize constant with a value of 10 - Added check in ReceiveMany to limit messages to awsMaxBatchSize

🐇✨
Changes afoot, in the code we weave,
A nonce refreshed, before the loop we leave.
With timeouts set, and contexts clear,
Our code hops forward, without any fear. 🚀🐾

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

---

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit-tests for this file.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit tests for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository from git and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit tests.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• The JSON schema for the configuration file is available here.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

[coderabbitai]

Review Status

Actionable comments generated: 3

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between ab5568c and 1df3e72.

Files selected for processing (1)

• core/transactor/tracker/noncer.go (2 hunks)

Additional comments: 1

core/transactor/tracker/noncer.go (1)

• 36-36: The call to n.refreshConfirmedNonce(ctx) before entering the timer loop in RefreshLoop method is a good change for ensuring the nonce is initialized before processing begins. This aligns with the PR's objective of initializing the nonce before loop execution.

[coderabbitai]

Review Status

Actionable comments generated: 2

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between 1df3e72 and c1794a8.

Files selected for processing (4)

• core/transactor/config.go (1 hunks)
• core/transactor/tracker/noncer.go (2 hunks)
• core/transactor/transactor.go (5 hunks)
• types/queue/sqs/sqs.go (2 hunks)

Files skipped from review due to trivial changes (1)

• core/transactor/config.go

Files skipped from review as they are similar to previous changes (1)

• core/transactor/tracker/noncer.go

Additional comments: 3

types/queue/sqs/sqs.go (2)

• 18-18: The introduction of awsMaxBatchSize with a value of 10 is a good practice to ensure that the number of messages being processed does not exceed the AWS SQS maximum batch size limit. This change enhances the robustness of the message processing logic.
• 129-131: The addition of a check in the ReceiveMany method to ensure the requested number of messages does not exceed awsMaxBatchSize is a crucial improvement. It prevents potential errors from AWS SQS when attempting to receive more messages than the allowed batch size. This change effectively aligns with best practices for interacting with AWS SQS.

core/transactor/transactor.go (1)

• 18-25: > 📝 NOTE

This review was outside the diff hunks, and no overlapping diff hunk was found. Original lines [1-1]

The changes in this file do not directly address the PR objectives related to nonce initialization and network call timeouts in the Noncer component. It's possible that the relevant changes are located in other parts of the codebase not included in this review. Ensure that the changes fulfilling the PR objectives are implemented and reviewed in the appropriate components.