fix(docker): move env to main yml, add names to fix db backup

berdal84 · Apr 26, 2024 · 179c1d7 · 179c1d7
1 parent ba4389a
commit 179c1d7
Show file tree

Hide file tree

Showing 5 changed files with 23 additions and 17 deletions.
diff --git a/api/docker-compose.dev.yml b/api/docker-compose.dev.yml
@@ -3,12 +3,8 @@ services:
   api:
     build:
       context: .
-      tags:
-        - "seeking/api:DEV"
     volumes:
       - .:/app/
     environment:
       DEBUG: True
     restart: on-failure
-    ports:
-      - 8000:8000
diff --git a/db/docker-compose.dev.yml b/db/docker-compose.dev.yml
@@ -1,12 +1,6 @@
 services:
   db:
     image: postgres:14
-    environment:
-      POSTGRES_DB: seeking
-      POSTGRES_USER: postgres
-      POSTGRES_PASSWORD: postgres
-    ports:
-      - 5432:5432
     healthcheck:
       #
       # This container can be up be not ready to accept connections, we run a healthcheck.
@@ -18,7 +12,7 @@ services:
       #
       # See doc: https://docs.docker.com/reference/dockerfile/#healthcheck
       #
-      test: ["CMD-SHELL", "pg_isready -U postgres"]
+      test: ["CMD-SHELL", "pg_isready"]
       start_interval: 1s
       start_period: 5s
       interval: 5s

diff --git a/docker-compose.yml b/docker-compose.yml
@@ -37,17 +37,26 @@ services:
 #--------------------------------------------------------------------------------------------
 #
   webui:
+    container_name: 'seeking-webui'
     restart: on-failure
     profiles: ['webui', '']
     extends:
       file: ./webui/docker-compose.dev.yml
       service: webui
+    build:
+      args:
+        - API_BASE_URL=http://127.0.0.1:8000
+    ports:
+      - 3000:3000
 #
 #--------------------------------------------------------------------------------------------
 #
   api:
+    container_name: 'seeking-api'
     restart: on-failure
     profiles: ['api', '']
+    ports:
+      - 8000:8000
     environment:
       DATABASE_HOST: db
       APP_HOST: api
@@ -64,11 +73,18 @@ services:
 #--------------------------------------------------------------------------------------------
 #
   db:
+    container_name: 'seeking-db'
     restart: always
+    environment:
+      POSTGRES_DB: seeking
+      POSTGRES_USER: postgres
+      POSTGRES_PASSWORD: postgres
   # profile: always active
     extends:
       file: ./db/docker-compose.dev.yml
       service: db
+    ports:
+      - 5432 # internal only
 #
 #--------------------------------------------------------------------------------------------
 #
diff --git a/webui/Dockerfile → webui/Dockerfile.standalone b/webui/Dockerfile → webui/Dockerfile.standalone
diff --git a/webui/docker-compose.dev.yml b/webui/docker-compose.dev.yml
@@ -2,9 +2,9 @@ services:
   webui:
     build:
       context: .
-      tags:
-        - "seeking/webui:DEV"
-      args:
-        - API_BASE_URL=http://127.0.0.1:8000
-    ports:
-      - 3000:3000
+      dockerfile: Dockerfile.standalone
+      # 
+      # You can override this at build time
+      #
+      # args:
+      #  - API_BASE_URL=<host>:<port>