Adding Japanese game support #379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Most of these likely work. I suspect some still don't work, but will have to discover them along the way.
|
Forgot to note, the changes to |
Fellshadow
approved these changes
Apr 21, 2023
Comment on lines
+414
to
+417
| [0x00630000] = { -- Japanese | ||
| versionName = "Pokemon FireRed J", | ||
| versionIndex = 7, | ||
| }, |
There was a problem hiding this comment.
Could be worth mentioning the v1.0 here? (either directly in versionName or as a comment, just so the note is there for anyone else who looks at this)
There was a problem hiding this comment.
Part of why i left this out is my lack of research to know what rom i was using and what roms are possible. I think the rom im using is 1.0. and I think its the only one that exist. but im not entirely sure. I dont have a different version that i found that i could test.
There was a problem hiding this comment.
hm yeah, that's fair i suppose
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds compatibility support to allow the Tracker to play Japanese FireRed ROMs, similar to how it can play other non-English games. This is only now possible because of the support for Japanese character rendering in Bizhawk 2.9. As for mGBA, it technically displays these text characters fine, but the formatting is still messy because there is no way to properly determine the length of a UTF16 string in this context.
The translations were imported from this Github repo.
I had to do some hacking in
GameSettingsto allow for Japanese ROM addresses, mostly cause EWRAM and IWRAM were different. I want to say that 99% of the addresses are correct, but it's possible some of them may not work.