Usager: remove font awesome #4912
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Je close pour le moment, je vais retirer les icônes dans des PR séparées EDIT: Done ✅ |
AntoineGirard
force-pushed
the
agd/remove-font-awesome-usager
branch
from
2236aa7 to
a637cad
Compare
francois-ferrandis
approved these changes
Jan 9, 2025
There was a problem hiding this comment.
Ça fait plaisir ! 🧹
Pour info j'avais utilisé un outil pour visualiser ta tailles assets dans cette PR, ça permettait d'avoir des visuels dans les PR et de se rendre compte de la taille relative de chaque lib avant / après : #2672
|
@francois-ferrandis |
AntoineGirard
force-pushed
the
agd/remove-font-awesome-usager
branch
from
a637cad to
35c0b1d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Review app
Review app
Contexte
Il semble que nous n’utilisons plus aucune icône font awesome côté usager. On peut donc retirer l’import.
Pour info :
application.css