IT-4359 | Update to yarn v3 #215
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
rogatty
commented
Oct 27, 2022
rogatty
commented
- https://bethink.atlassian.net/browse/IT-4359
- https://yarnpkg.com/getting-started/migration
- https://yarnpkg.com/features/offline-cache
- https://github.com/bethinkpl/wnl-platform/pull/3946
rogatty
commented
Oct 27, 2022
| @@ -58,6 +58,7 @@ | |||
| "jest": "26.1.0", | |||
| "jsdom": "^19.0.0", | |||
| "jsdom-global": "^3.0.2", | |||
| "node-gyp": "9.3.0", | |||
There was a problem hiding this comment.
Fix for:
Usage Error: Couldn't find a script name "node-gyp" in the top-level (used by deasync@npm:0.1.21). This typically happens because some package depends on "node-gyp" to build itself, but didn't list it in their dependencies. To fix that, please run "yarn add node-gyp" into your top-level workspace. You also can open an issue on the repository of the specified package to suggest them to use an optional peer dependency.
I found vuejs/vue-jest#403 but didn't go any deeper yet.
rogatty
commented
Oct 27, 2022
| @@ -44,7 +44,7 @@ | |||
| "@types/node": "^17.0.9", | |||
| "@typescript-eslint/eslint-plugin": "5.40.1", | |||
| "@typescript-eslint/parser": "5.40.1", | |||
| "@vue/cli-plugin-typescript": "^5.0.8", | |||
| "@vue/cli-plugin-typescript": "^4.5.13", | |||
There was a problem hiding this comment.
It's causing build to fail on master.
rogatty
commented
Oct 27, 2022
rogatty
commented
Oct 28, 2022
Comment on lines
+20
to
+23
| - name: Insert auth font awesome auth token | ||
| run: yarn config set npmScopes.fortawesome.npmAuthToken $FONT_AWESOME_AUTH_TOKEN | ||
| env: | ||
| FONT_AWESOME_AUTH_TOKEN: ${{ secrets.FONT_AWESOME_AUTH_TOKEN }} |
There was a problem hiding this comment.
rogatty
commented
Oct 28, 2022
| "@fortawesome/vue-fontawesome": "2.0.6", | ||
| "@storybook/addon-controls": "^6.5.13", | ||
| "@storybook/addon-docs": "^6.5.13", | ||
| "@storybook/addon-storysource": "^6.5.13", | ||
| "@storybook/addon-viewport": "^6.5.13", | ||
| "@storybook/vue": "^6.5.13", | ||
| "@types/jest": "29.2.0", |
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.