update SurveyQuestionScale layout #332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rogatty
reviewed
Jan 10, 2024
lib/js/components/SurveyQuestions/SurveyQuestionScale/SurveyQuestionScale.vue
Show resolved
Hide resolved
rogatty
reviewed
Jan 12, 2024
| @@ -2,3 +2,8 @@ export const SURVEY_QUESTION_STATES = { | |||
| DEFAULT: 'default', | |||
| DISABLED: 'disabled', | |||
| } as const; | |||
|
|
|||
| export const SURVEY_QUESTION_CONTAINERS = { | |||
There was a problem hiding this comment.
I'd rename it to SURVEY_QUESTION_SCALE_CONTAINERS as there are no plans to use it outside SurveyQuestionScale.
rogatty
reviewed
Jan 12, 2024
| } | ||
| } | ||
|
|
||
| .-visibleOnMobile { |
There was a problem hiding this comment.
We already have -hideOnMobile so I'd rename it to -hideOnDesktop. Hiding is what it actually does. It's being used only with surveyQuestionScale__toggle so consider moving it there.
rogatty
reviewed
Jan 12, 2024
Comment on lines
+204
to
+206
| &.-justifyEnd { | ||
| justify-content: flex-end; | ||
| } |
There was a problem hiding this comment.
You won't let Tailwind go without a fight, huh? 😆
rogatty
approved these changes
Jan 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.