Add simple Disabled marker #17514
Open
Add simple Disabled marker #17514
+63
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenjaminBrienen
added
C-Feature
|
I think that this should close that issue. Would you mind fixing the description? :) |
MrGVSV
reviewed
Jan 23, 2025
|
|
||
| let disabled = self.register_component::<Disabled>(); | ||
| let mut filters = DefaultQueryFilters::default(); | ||
| filters.set_disabled(disabled); |
There was a problem hiding this comment.
I'm a bit worried that users might do a
app.init_resource::<DefaultQueryFilters>()
and lose the Disabled functionality inadvertently..
There was a problem hiding this comment.
init_resource doesn't overwrite existing resources. You'd have to explicitly call .insert_resource(DefaultQueryFilters::default()) which is probably verbose enough to make it obvious what will happen. Currently it is intended that you can opt-out of entity disabling, but as the feature matures we could consider making it so that it is always there.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
We have default query filters now, but there is no first-party marker for entity disabling yet
Fixes #17458
Solution
Add the marker, cool recursive features and/or potential hook changes should be follow up work
Testing
Added a unit test to check that the new marker is enabled by default