Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Mangaung & NMB areas #454

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Add Mangaung & NMB areas #454

wants to merge 5 commits into from

Conversation

IamC8
Copy link

@IamC8 IamC8 commented Jun 30, 2023

Ok, I have started over again. Understand GitHub better now. These are the proposed changes

IamC8 and others added 5 commits June 30, 2023 22:02
@beyarkay
Copy link
Owner

beyarkay commented Jul 4, 2023

Hi there, I need to know the source of your information for the changed areas as previously mentioned. I see you said this URL was for mangaung:

But please also provide a URL for NMB.

@beyarkay beyarkay changed the title Changes Add Mangaung & NMB areas Jul 4, 2023
@beyarkay
Copy link
Owner

Hi there, apologies for the long delay, I had to focus on some personal things for a while.

For the Mangaung changes, all looks good. I'm happy to merge them in, although there are some issues with the NMB schedules (see below). If you open up a new PR with just the Mangaung changes then I'll merge that PR. Thanks!

The NMB schedules are no longer up-to-date because NMB has updated their schedules (the latest one looks like it covers 4 September 2023 - 3 December 2023).

It's not feasible for me to re-calculate the schedules every couple of months, so a NMB schedule would have to be resilient to this sort of change. The main codebase supports a different format for the CSVs which could help with this. Instead of specifying the date of the month, you can specify a periodic schedule that has an arbitrary start and arbitrary repetition frequency.

For example, to specify a schedule that repeats every 19 days and started on the 15th September 2023:

nelson-mandela-bay-group-1.csv

day_of_cycle, period_of_cycle, start_of_cycle, start_time, finsh_time, stage
           1,              19, 2023-09-15    , 00:00     , 02:30     ,     1
           1,              19, 2023-09-15    , 00:00     , 02:30     ,     2
           1,              19, 2023-09-15    , 00:00     , 02:30     ,     3
           1,              19, 2023-09-15    , 18:00     , 20:30     ,     3
           1,              19, 2023-09-15    , 00:00     , 02:30     ,     4
           1,              19, 2023-09-15    , 08:00     , 10:30     ,     4
           1,              19, 2023-09-15    , 18:00     , 20:30     ,     4

(whitespace added for clarity)

As per the updated schedule for NMB:
Screenshot 2023-09-21 at 12 12 01

If the NMB schedules are specified in this way, I think they won't need to be updated every 3 months because the new schedules announced by NMB would match the ones predicted by the periodic schedule.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants