Jan development #431
Open
Jan development #431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 24, 2024 19:26
abouolia
reviewed
Apr 30, 2024
| @@ -0,0 +1,433 @@ | |||
| /*! normalize.css v8.0.1 | MIT License | github.com/necolas/normalize.css */ | |||
There was a problem hiding this comment.
Avoid adding these kind of files in the PR since not related to it.
| @@ -526,6 +526,10 @@ html[lang^=en] body { | |||
| border-top: 3px double #666; | |||
| font-weight: bold; | |||
| } | |||
| .invoice__table-total table tbody tr.total td { | |||
There was a problem hiding this comment.
That kind of change would be better if it was in another PR.
| exports.up = function (knex) { | ||
| return knex.schema.createTable('user_tenants', (table) => { | ||
| table.increments(); | ||
| table.integer('user_id'); |
There was a problem hiding this comment.
No database relation to users and tenants table.
| const tenant = await Tenant.query() | ||
| .findById(user.tenantId) | ||
| .withGraphFetched('metadata'); | ||
| const tenant = await UserTenants.query() |
There was a problem hiding this comment.
Instead of exposing all the tenants data in sign-in response would be better to add another endpoint retrieves all associated tenants to the current authenticated user.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Integrated API to get data of tenants