use tokenizer.chat_template by default for instruction type tasks #301
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Use
tokenizer.chat_template
(if exists) for instruction type tasks by default.Issue Addressed
This address the issue for models such as
google/gemma-2-2b-it
, where the instruction tokens areHowever, in the current implementation, because of string escaping, the prompt template escapes
\n
to\\n
, which makes the final template different from the model's actual template. Additionally the current implementation doesn't add<bos>
for tokenizers that use them by default.Notes
Only tested on
instruct-humaneval
forgoogle/gemma-2-2b-it
andmeta-llama/Llama-3.2-1B-Instruct
for now.