Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update peft dependency, fix initialization and inference with new peft #557

Merged
merged 9 commits into from
Jul 22, 2024

Conversation

artek0chumak
Copy link
Collaborator

@artek0chumak artek0chumak commented Feb 27, 2024

Make possible to use up-to-date PEFT library.

TODO:

  • Fix initialization
  • Fix inference without adapters
  • Fix init for quantized modules
  • Fix debug messages while server initialization

@artek0chumak artek0chumak marked this pull request as ready for review March 5, 2024 09:53
Copy link
Collaborator

@justheuristic justheuristic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

src/petals/utils/peft.py Outdated Show resolved Hide resolved

class LoraLinear8bitLt(AdapterContextMixin, lora.Linear8bitLt):
# TODO: Check if lora.Linear can be mixed with lora.Linear8bitLt
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this checked?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I checked that it worked, and the outputs were the same.

@justheuristic justheuristic changed the title Peft update Update peft dependency, fix initialization and inference with new peft Jul 22, 2024
@artek0chumak artek0chumak merged commit f1e1b05 into main Jul 22, 2024
11 checks passed
@artek0chumak artek0chumak deleted the peft_update branch July 22, 2024 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants