Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restrict snappy pull-raw-data to FASTQ files #118

Conversation

eudesbarbosa
Copy link
Member

@eudesbarbosa eudesbarbosa commented Sep 8, 2022

closes #29 , closes #113

Changes

  • Restrict snappy pull-raw-data to FASTQ files. Default behavior: looks for FASTQ file names that contain the sample identifier. Otherwise, it looks for path in SODAR that contain the library names (e.g., 'P001-N1-DNA1-WGS1').
  • Repurposed old pull-raw-data as pull-all-data. As the name suggests it will download all data associated with a sample from SODAR.

@eudesbarbosa
Copy link
Member Author

eudesbarbosa commented Sep 8, 2022

Note: The default behavior might address some of the corner-cases in #62, as it is not based on the library name. It at least download all data marking the library_name.

@eudesbarbosa eudesbarbosa force-pushed the 113-restrict-snappy-pull-raw-data-fastq branch from a33f876 to d68d8fa Compare September 8, 2022 11:44
@eudesbarbosa eudesbarbosa marked this pull request as ready for review September 8, 2022 13:02
Copy link
Member

@holtgrewe holtgrewe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eudesbarbosa eudesbarbosa merged commit af0ed39 into bihealth:master Sep 9, 2022
@eudesbarbosa eudesbarbosa deleted the 113-restrict-snappy-pull-raw-data-fastq branch September 9, 2022 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Restrict snappy pull-raw-data to raw data Allow better selection for cubi-tk sodar pull-raw-data
2 participants