Skip to content

Commit

Permalink
Rename ARM Vector Floating Point templates to avoid clash (BugFix) (c…
Browse files Browse the repository at this point in the history
…anonical#949)

* Rename ARM Vector Floating Point template units to avoid clash

These two templates use the same `id` which is a problem when ensuring
every template has a unique id field.

* Update test plans accordingly
  • Loading branch information
pieqq authored and binli committed Mar 22, 2024
1 parent 48ee5a1 commit 83ebe11
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 5 deletions.
4 changes: 2 additions & 2 deletions providers/base/units/cpu/jobs.pxu
Original file line number Diff line number Diff line change
Expand Up @@ -176,7 +176,7 @@ template-filter: cpuinfo.platform == 'armv7l'
template-unit: job
plugin: shell
category_id: com.canonical.plainbox::cpu
id: cpu/arm_vfp_support_{platform}
id: cpu/armhf_vfp_support_{platform}
estimated_duration: 1.0
user: root
command:
Expand All @@ -192,7 +192,7 @@ template-filter: cpuinfo.platform == 'aarch64'
template-unit: job
plugin: shell
category_id: com.canonical.plainbox::cpu
id: cpu/arm_vfp_support_{platform}
id: cpu/arm64_vfp_support_{platform}
estimated_duration: 1.0
user: root
command:
Expand Down
8 changes: 5 additions & 3 deletions providers/base/units/cpu/test-plan.pxu
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,8 @@ include:
cpu/clocktest
cpu/offlining_test
cpu/topology
cpu/arm_vfp_support_.*
cpu/armhf_vfp_support_.*
cpu/arm64_vfp_support_.*
cpu/cstates
cpu/cstates_results.log

Expand All @@ -99,6 +100,7 @@ include:
cpu/maxfreq_test certification-status=blocker
cpu/maxfreq_test-log-attach certification-status=non-blocker
cpu/topology certification-status=blocker
cpu/arm_vfp_support_.* certification-status=non-blocker
cpu/armhf_vfp_support_.* certification-status=non-blocker
cpu/arm64_vfp_support_.* certification-status=non-blocker
cpu/cstates certification-status=non-blocker
cpu/cstates_results.log certification-status=non-blocker
cpu/cstates_results.log certification-status=non-blocker

0 comments on commit 83ebe11

Please sign in to comment.