Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicit Consent Versioning #548

Merged
merged 4 commits into from
Nov 29, 2023
Merged

Conversation

cassidysymons
Copy link
Collaborator

This PR implements explicit consent versioning and refactors the is_consent_required function accordingly.

Importantly, we're still operating under the assumption that all locales and age groups will be operating on the same version of the consent documents. If that changes at some point in the future, it will likely require significant changes to microsetta-private-api, microsetta-interface, and microsetta-admin.

@cassidysymons cassidysymons marked this pull request as ready for review November 29, 2023 21:52
@cassidysymons cassidysymons requested a review from wasade November 29, 2023 21:52
Copy link
Member

@wasade wasade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor suggested change

microsetta_private_api/repo/consent_repo.py Show resolved Hide resolved
microsetta_private_api/repo/consent_repo.py Outdated Show resolved Hide resolved
@cassidysymons cassidysymons merged commit 1d27176 into master Nov 29, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants