Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some suggestions #8

Merged
merged 5 commits into from
Feb 13, 2024
Merged

Some suggestions #8

merged 5 commits into from
Feb 13, 2024

Conversation

trangdata
Copy link
Contributor

@trangdata trangdata commented Feb 13, 2024

Here are some of my suggestions after the first pass. Please feel free to accept/edit/decline as you see fit. Main points:

@trangdata
Copy link
Contributor Author

One comment I have is wrt Fig. 3 biochatter_benchmark: it's a little difficult for me to read/interpret this figure, e.g. I can't find values for chatglm3. I know it's challenging because we don't have the full grid of models x sizes x quantisation levels, but I wonder if jittering or faceting would help somehow.

Also, in the main text, we haven't discussed model "size", and given that there is not really an association between size and performance, maybe we don't need to visualize this dimension? (We can include a table of all the values and sizes in Supplement) And if so, I wonder if a graph of Mean Accuracy vs. Model would be a little clearer, and the point size would refer to the quantisation level instead. Just a thought.

@slobentanzer
Copy link
Contributor

Good points, thanks a lot for the feedback! Will go over and merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants