feat: protect chat attributes and improve error handling #262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
slobentanzer
commented
Jan 15, 2025
slobentanzer
commented
- Add property decorators to protect chat and ca_chat attributes in Conversation ABC
- Make user parameter optional in all conversation classes
- Add clear error messages when chat attributes accessed before initialization
- Reset chat attributes on authentication failure
- Add tests for new chat attribute behavior
- Add property decorators to protect chat and ca_chat attributes in Conversation ABC - Make user parameter optional in all conversation classes - Add clear error messages when chat attributes accessed before initialization - Reset chat attributes on authentication failure - Add tests for new chat attribute behavior
slobentanzer
had a problem deploying
to
Test CI
GitHub Actions
Failure
slobentanzer
had a problem deploying
to
Test CI
GitHub Actions
Failure
slobentanzer
had a problem deploying
to
Test CI
GitHub Actions
Failure
slobentanzer
had a problem deploying
to
Test CI
GitHub Actions
Failure
This was referenced Jan 15, 2025
mengerj
approved these changes
Jan 16, 2025
There was a problem hiding this comment.
Looks good to me. I didn't run any tests as I have some other Issues regarding installing the project with Poetry. I see that you changed the version, which was a problem for me before. But now poetry doesn't find my python executable and so far I couldn't fix it.
|
@mengerj I changed the Poetry version in the CI, as they apparently did a major bump and that's not compatible. The project still is based on Poetry >1 <2. Have you tried poetry env use to tell Poetry where to look? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.