Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve pretty validation errors and update example notebook #605

Merged
merged 20 commits into from
Jun 10, 2024

Conversation

FynnBe
Copy link
Member

@FynnBe FynnBe commented May 29, 2024

@esgomezm please check this out if you find the time

@github-actions github-actions bot added ci Continuous Integration github_actions Pull requests that update Github_actions code labels May 29, 2024
@esgomezm
Copy link
Contributor

Perfect! Can you please tell me a deadline or something? do you need it for Madrid for example or shall I do it while there?

@esgomezm
Copy link
Contributor

esgomezm commented Jun 3, 2024

@FynnBe did you update the notebook? or will I see it once I test it? (I don't see any notebook change in the commits)

@FynnBe
Copy link
Member Author

FynnBe commented Jun 3, 2024

working on it. haven't commited that yet. (that's why this is still a draft PR)

@FynnBe
Copy link
Member Author

FynnBe commented Jun 3, 2024

sorry, tagging you was for demo purposes in the last BMZ meeting when we discussed the "release check project"

@esgomezm
Copy link
Contributor

esgomezm commented Jun 3, 2024

AH! ok

@FynnBe FynnBe requested a review from esgomezm June 3, 2024 09:33
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Jun 5, 2024
FynnBe added 7 commits June 5, 2024 15:18
(unicode emojis are 2 chars long)
also allow DatasetDescr02 for training_data
attempt head request first, if forbidden, follow up with a get request
that is streamed and if that is also forbidden a regular get request
@FynnBe FynnBe marked this pull request as ready for review June 7, 2024 14:40
@FynnBe FynnBe merged commit 81a8ec5 into main Jun 10, 2024
8 checks passed
@FynnBe FynnBe deleted the update_example branch June 10, 2024 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Continuous Integration documentation Improvements or additions to documentation github_actions Pull requests that update Github_actions code
Projects
Status: Released 📢
Development

Successfully merging this pull request may close these issues.

2 participants