bugfix/scyjava-testing-fix #19
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BrianWhitneyAI
requested review from
toloudis,
hughes036,
evamaxfield,
aswallace,
SeanLeRoy and
yrkim98
BrianWhitneyAI
commented
Jan 27, 2025
| @@ -196,7 +187,7 @@ | |||
| (1, 3, 1, 1024, 1024), | |||
| np.uint16, | |||
| dimensions.DEFAULT_DIMENSION_ORDER, | |||
| ["Red", "Green", "Blue"], | |||
| ["Channel:0:0", "Channel:0:1", "Channel:0:2"], | |||
There was a problem hiding this comment.
This is actually a return to what we had before. The last commit to main updated it to ["Red", "Green", "Blue"]
BrianWhitneyAI
commented
Jan 27, 2025
| @@ -383,9 +374,9 @@ def test_bioformats_reader_large_files( | |||
| ( | |||
| "S=2_4x2_T=2=Z=3_CH=2.czi", | |||
| "S=2_4x2_T=2=Z=3_CH=2.czi #1", | |||
| (2, 2, 3, 487, 947), | |||
| (2, 2, 3, 488, 948), | |||
There was a problem hiding this comment.
Not sure what caused this minor pixel increase...
There was a problem hiding this comment.
Can we load the file in Zen and see what dimensions it reports?
SeanLeRoy
approved these changes
Jan 29, 2025
toloudis
approved these changes
Feb 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Ci broken on main branch. This PR removes some weird logic about the depreciated bioformats_jar that was skipping running our tests. Additionally this returns the values of one of our tests that was modified back to its original value, while reassigning dims to another test. (The second change I am not sure of the source).
Also resolves #10