feat(format/html): implement bracketSameLine #4968
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dyc3
commented
Jan 24, 2025
| write!(f, [soft_line_break_or_space()])?; | ||
| } | ||
|
|
||
| // TODO: These tokens (the `/>`) are not yet borrowed by sibling elements for whitespace sensitivity. |
There was a problem hiding this comment.
whitespace sensitivity is not yet implemented for self closing elements
CodSpeed Performance ReportMerging #4968 will not alter performanceComparing Summary
|
dyc3
force-pushed
the
html-bracket-same-line
branch
2 times, most recently
from
e583d33 to
8afc1a8
Compare
dyc3
force-pushed
the
html-bracket-same-line
branch
from
8afc1a8 to
b27188e
Compare
This comment was marked as resolved.
This comment was marked as resolved.
dyc3
force-pushed
the
html-bracket-same-line
branch
from
b27188e to
82f9a47
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR implements functionality for the
bracketSameLineoption, with a particular focus on matching prettier's emitted IR.closes #4024
Test Plan
added tests