Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(migrate): migrate to includes #4974

Merged
merged 2 commits into from
Jan 27, 2025
Merged

Conversation

Conaclos
Copy link
Member

Summary

Part of #4611

Add a migration rule to turn include/ignore into includes.
biome migrate will emit a diagnostic when it encounters a glob pattern that it is not able to convert.
It ignores them.

Test Plan

I added some tests.

@Conaclos Conaclos changed the base branch from main to next January 26, 2025 21:58
@github-actions github-actions bot added A-CLI Area: CLI A-Linter Area: linter A-Changelog Area: changelog labels Jan 26, 2025
@Conaclos Conaclos changed the title Conaclos/config includes migrate feat(migrate): migrate to includes Jan 26, 2025
@Conaclos Conaclos requested review from a team January 26, 2025 21:58
Copy link

codspeed-hq bot commented Jan 26, 2025

CodSpeed Performance Report

Merging #4974 will not alter performance

Comparing conaclos/config-includes-migrate (1243242) with next (e5d99df)

Summary

✅ 95 untouched benchmarks

Copy link
Member

@ematipico ematipico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please run the migration against our biome.jsonc and see if everything works?

@github-actions github-actions bot removed A-Linter Area: linter A-Changelog Area: changelog labels Jan 27, 2025
@Conaclos
Copy link
Member Author

Can you please run the migration against our biome.jsonc and see if everything works?

Done.
I had to update our test script to handle JSONC correctly. It seems that other migration rule don't test JSONC.

@Conaclos Conaclos merged commit 3538867 into next Jan 27, 2025
11 checks passed
@Conaclos Conaclos deleted the conaclos/config-includes-migrate branch January 27, 2025 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-CLI Area: CLI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants