Enforce max startup power #155
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
damosvil
force-pushed
the
feature/enforce_max_startup_power
branch
from
1a784fd to
01d19fa
Compare
damosvil
force-pushed
the
feature/enforce_max_startup_power
branch
2 times, most recently
from
ee38e96 to
77da5ce
Compare
|
Converted to draft until backport is merged to keep only one commit |
…g the esc/motor durign startup. This has an special effect on crashes because max power was not limited during startup phases Fixed some bugs Fixed review comments Fixed review findings Removed unnecesary initialization in exit_run_mode before jumping to motor_start
damosvil
force-pushed
the
feature/enforce_max_startup_power
branch
from
77da5ce to
5cdffe3
Compare
|
Closing because of it will be included in the rebase |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit aims to enforce limiting startup power to avoid destroying the esc/motor during startup. This has a special effect on crashes because max power was not limited during startup phases.
This bug has been inherited from Blheli_S:
https://github.com/bitdump/BLHeli/blob/20c36c2695c5b5ea855288e0046313688d1367a5/BLHeli_S%20SiLabs/BLHeli_S.asm#L1683