Flag_Ext_Tele can only be cleared in exit_run_mode when motors are not being reversed (turtle mode) #179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t being reversed (turtle mode)
hyp0dermik-code
approved these changes
Nov 12, 2023
There was a problem hiding this comment.
Confirmed that this fixes the bug described. Also thanks to Damosvil for the explanation, this flag should not be cleared until https://github.com/bird-sanctuary/bluejay/blob/80bd58803c50c0a9820634c2293101e299603e02/src/Bluejay.asm#L1073C22-L1073C22
at the earliest
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Flag_Ext_Tele can only be cleared in exit_run_mode when motors are not being reversed (turtle mode)
That step is done in the lowest part of exit_run_mode