-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Version 4 format features #146
base: main
Are you sure you want to change the base?
Conversation
Is this patch still viable for making it in? I don't see anyone having reviewed it yet. |
it has not been reviewed yet indeed. based on the description, it still needs a bit of work on the block version selection before being merged. |
@divarvel It's been a while since I worked on this code, but I'm looking forward to your review! |
This PR implements several v4 format features:
Along the way I solved several bugs and added some unit tests.
Since this is a very large PR, I suggest to review it commit by commit.
Also, since it still doesn't implement all of the v4 format, please merge it into a separate branch for now.
Lastly, just like #142, this implementation does not minimize the version number when serializing. I need your help in understanding the relevant code.