jade: update Jade api to 1.0.33 #768
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
…m repo Do not clone submodules recursively as an unused upstream module has disappeared, and the qemu build handles fetching submodules as needed. Also add flag to clone submodules without their entire history.
This extends the serial api to recognise recently supported hardware.
JamieDriver
force-pushed
the
update_jade_api
branch
from
d1ecba9 to
f4f7fe5
Compare
|
ACK f4f7fe5 |
achow101
added a commit
that referenced
this pull request
Jan 3, 2025
c66dd1a jade: use Jade's native PSBT signing if the firmware version supports it (Jamie C. Driver) Pull request description: 1. latest jade api to recognise more recently added hw (now available as its own PR, #768) 2. remove code which walked psbt and mapped it into Jade's legacy 'sign_tx' json format - instead pass PSBT directly to Jade for signing, since this has been supported in fw now for well over a year and seems to be working well. ACKs for top commit: achow101: ACK c66dd1a Tree-SHA512: e6c80f7309995ba4bf7cc5f9185ad89d45e84226d05cc0ec8741b3a9eead3bda7f4d99e94a16041c6acb2a103719f64f4c2879ed79be6d901cbac4c13ffb689b
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This extends the serial api to recognise recently supported hardware.