CSS fix on links in sidebar #604
Conversation
|
What problem does this solve? |
|
Sorry should have left a description. Just a style patch for the links that are in the sidebar component in the getting started pages (/buy-bitcoin-cash/ ex) The text links within the paragraph needed to be specified to inline so they dont break lines |
|
I said the wrong word. I want the links to break. Currently they take an entire line of the paragraph like you are describing above. By making them inline they should flow with the paragraph right? I'm seeing the opposite of what youre describing with this change. Are you seeing that running this or thats what you see on the live site? |
|
Ok so your problem is that the sidebar display are defined as flex, which is good, but every child is also defined as flex, which is definitely wrong. You need to fix the sidebar CSS instead of doing this. |
|
You want to change this into |
specified a class for the section links so flex is not applied to all <a>s
|
Okay I specified a class for the links that need flex so it doesnt get applied to the others |
|
|
this doesnt work for the rows that need to be links on the wallet page |
|
those are a children too and need specific style |
| display: flex; | ||
| color: #444; | ||
| transition: all 300ms; | ||
| } | ||
|
|
||
| .card a:hover { | ||
| .clickableRow:hover { |
There was a problem hiding this comment.
Why is this clickableRow now?
There was a problem hiding this comment.
thats the class name
|
This is wrong: https://github.com/bitcoincashorg/bitcoincash.org/pull/604/files#diff-c084369006e972f978373026b3dc660cR14 It defines all the childs as flex too. |
|
yes thats why I added the class before. Some of the links in the sidebar need different styling |
|
There are no other links in your patch that use the class, so I still don't see how any of this makes any sense. |
|
There are two possible types of links that need different styling in this sidebar component. One is the type that I made this class for. It needs display: flex some colors etc. These are the anchor links that take you to different sections found on the wallet page for example that take up a whole row. The other type is a link within the paragraph text. These only need their color defined and the rest of the default styling is fine. So I selected them through their parent class and applied the color no class needed |
|
The anchor links are not immediate childs of .card are they? The these anchor link cannot appear anywhere else. So why |
|
The anchor links are not direct children of .card. They are children of .cardIconRow so .cardIconRow > a works |
* css fix on links * CSS cleanup specified a class for the section links so flex is not applied to all <a>s * remove class * add a class * remove class use child selector
No description provided.