Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: pin rustls for msrv #1802

Merged
merged 1 commit into from
Jan 16, 2025
Merged

ci: pin rustls for msrv #1802

merged 1 commit into from
Jan 16, 2025

Conversation

ValuedMammal
Copy link
Contributor

@ValuedMammal ValuedMammal commented Jan 15, 2025 •
edited
Loading

Fix the current CI issue by pinning rustls again to 0.23.19

@ValuedMammal
Copy link
Contributor Author

ValuedMammal commented Jan 15, 2025 •
edited
Loading

Hm, not sure if merging is blocked because this didn't run on rust 1.83. If so, I can revert the last commit.

*Made a typo - rustls still pinned to 0.23.19

@ValuedMammal ValuedMammal changed the title ci,clippy: pin rustls to 0.23.21 + fix clippy nits + bump rust-version to 1.84 ci,clippy: pin rustls + fix clippy nits + bump rust-version to 1.84 Jan 15, 2025
oleonardolima
oleonardolima approved these changes Jan 15, 2025
View reviewed changes
Copy link
Contributor

@oleonardolima oleonardolima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK 5b4bf19

@tnull
Copy link
Contributor

tnull commented Jan 15, 2025

Hmm, I'm not sure if pinning rustls is a good idea going forward. In LDK / LDK Node we bumped the MSRV of crates dependent on rustls to 1.75.0, exactly to avoid doing that.

Please also see the discussion here, would love to get some more feedback: #1750

@ValuedMammal ValuedMammal changed the title ci,clippy: pin rustls + fix clippy nits + bump rust-version to 1.84 ci: pin rustls for msrv Jan 15, 2025
@ValuedMammal
Copy link
Contributor Author

@oleonardolima I had to drop the commit to update rust-version, so I guess we can address it on #1801

@ValuedMammal
Copy link
Contributor Author

Pinning rustls should be considered a temporary fix while we continue to hash out #1750

oleonardolima
oleonardolima approved these changes Jan 15, 2025
View reviewed changes
Copy link
Contributor

@oleonardolima oleonardolima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK e4cf5b5

@oleonardolima oleonardolima mentioned this pull request Jan 15, 2025
Open
@ValuedMammal ValuedMammal merged commit 1afa439 into bitcoindevkit:master Jan 16, 2025
21 checks passed
@ValuedMammal ValuedMammal deleted the ci/clippy branch January 16, 2025 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oleonardolima oleonardolima oleonardolima approved these changes

@LagginTimes LagginTimes Awaiting requested review from LagginTimes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ValuedMammal @tnull @oleonardolima