Skip to content

Commit

Permalink
gradle.properties: javaToolchainVersion = 23
Browse files Browse the repository at this point in the history
This sets the default toolchain to JDK 23. This does not change the supported
version of any of the outputs.

If for some reason you still need to build with JDK 22, you can use
the `-PjavaToolchainVersion=22` option to Gradle.

GitHub actions gradle.yml is also updated to no longer use the -P option
to override the toolchain version.
  • Loading branch information
msgilligan committed Nov 14, 2024
1 parent c5d471f commit 331bbca
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/gradle.yml
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,6 @@ jobs:
- name: Install secp256k1 with Nix
run: nix profile install nixpkgs#secp256k1
- name: Build with Gradle
run: ./gradlew -PjavaToolchainVersion=23 build
run: ./gradlew build
- name: Run Java & Kotlin Examples
run: ./gradlew -PjavaToolchainVersion=23 run runEcdsa
run: ./gradlew run runEcdsa
4 changes: 2 additions & 2 deletions gradle.properties
Original file line number Diff line number Diff line change
@@ -1,14 +1,14 @@
secpVersion = 0.0.1

# Major (whole number) version of JDK to use for javac, jlink, jpackage, etc.
javaToolchainVersion = 22
javaToolchainVersion = 23
# Vendor for javaToolChain. (Should be indicator string from Gradle's KnownJvmVendor enum or empty string)
# Official builds use 'Eclipse Adoptium'
#javaToolchainVendor = Eclipse Adoptium
javaToolchainVendor =

# Where to look for JDKs (via environment variables)
org.gradle.java.installations.fromEnv = JAVA_HOME, JDK22
org.gradle.java.installations.fromEnv = JAVA_HOME, JDK23

# Auto-detection can be disabled if you have multiple JDKs of the
# same version installed and Gradle won't reliably select the version you actually want
Expand Down

0 comments on commit 331bbca

Please sign in to comment.