Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kotlin examples: Use Bouncy256k1 #19

Merged
merged 1 commit into from
Mar 8, 2024

Conversation

msgilligan
Copy link
Member

@msgilligan msgilligan commented Mar 8, 2024

This is because Kotlin does not yet support JDK 22, so
we'll have to limit the Kotlin examples to the (incomplete) Bouncy
implementation for now...

This is a child of PR #18, but is ready to merge once PR #18 is merged.
Update: Rebased

@msgilligan msgilligan added the DRAFT Workaround for no DRAFT PRs in private, unpaid Repo label Mar 8, 2024
@msgilligan msgilligan added this to the Version 0.0.2 milestone Mar 8, 2024
@msgilligan msgilligan requested a review from schildbach March 8, 2024 16:16
Copy link
Member

@schildbach schildbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

be46189 approved.

This is because Kotlin does not yet support JDK 22, so
we'll have to limit the Kotlin examples to the (incomplete) Bouncy
implementation for  now...
@msgilligan msgilligan force-pushed the msgilligan/kotlin-examples-use-bouncy branch from be46189 to 46d672d Compare March 8, 2024 16:44
@msgilligan msgilligan removed the DRAFT Workaround for no DRAFT PRs in private, unpaid Repo label Mar 8, 2024
@msgilligan msgilligan merged commit 2186156 into master Mar 8, 2024
6 checks passed
@msgilligan msgilligan deleted the msgilligan/kotlin-examples-use-bouncy branch March 8, 2024 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants