Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI-2304] Progress indictor output change #899

Merged
merged 3 commits into from
Dec 6, 2023

Conversation

tothszabi
Copy link
Contributor

@tothszabi tothszabi commented Dec 6, 2023

Checklist

Version

Requires a PATCH version update

Context

This PR updates the go-utils package to have this code change in the CLI:
bitrise-io/go-utils#191

Other than that I have created a new wrapper for the progress indicator which will always inject our custom logger as the output.

This example output was taken with these changes:

{"timestamp":"2023-12-06T13:17:38.229375Z","type":"log","producer":"bitrise_cli","level":"normal","message":"Installing ⣾"}
{"timestamp":"2023-12-06T13:17:38.329614Z","type":"log","producer":"bitrise_cli","level":"normal","message":"\u0008"}
{"timestamp":"2023-12-06T13:17:38.329664Z","type":"log","producer":"bitrise_cli","level":"normal","message":"\u0008"}
{"timestamp":"2023-12-06T13:17:38.32967Z","type":"log","producer":"bitrise_cli","level":"normal","message":"\u0008"}
{"timestamp":"2023-12-06T13:17:38.329676Z","type":"log","producer":"bitrise_cli","level":"normal","message":"\u0008"}
{"timestamp":"2023-12-06T13:17:38.32968Z","type":"log","producer":"bitrise_cli","level":"normal","message":"\u0008"}
{"timestamp":"2023-12-06T13:17:38.329685Z","type":"log","producer":"bitrise_cli","level":"normal","message":"\u0008"}
{"timestamp":"2023-12-06T13:17:38.329689Z","type":"log","producer":"bitrise_cli","level":"normal","message":"\u0008"}
{"timestamp":"2023-12-06T13:17:38.329693Z","type":"log","producer":"bitrise_cli","level":"normal","message":"\u0008"}
{"timestamp":"2023-12-06T13:17:38.329698Z","type":"log","producer":"bitrise_cli","level":"normal","message":"\u0008"}
{"timestamp":"2023-12-06T13:17:38.329787Z","type":"log","producer":"bitrise_cli","level":"normal","message":"\u0008"}
{"timestamp":"2023-12-06T13:17:38.329796Z","type":"log","producer":"bitrise_cli","level":"normal","message":"\u0008"}
{"timestamp":"2023-12-06T13:17:38.329802Z","type":"log","producer":"bitrise_cli","level":"normal","message":"\u0008"}

@tothszabi tothszabi merged commit 3cbcaa8 into master Dec 6, 2023
2 checks passed
@tothszabi tothszabi deleted the CI-2304-progress-indictor-output-change branch December 6, 2023 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants