Skip to content

Commit

Permalink
Propose the deprecation of universal APK generation (#133)
Browse files Browse the repository at this point in the history
* Input deprecated

* Warn added to the deployment logic

* Warning message updated

* Ship addon hint inclueded in the warning message

* Deprecated added to the name of the input

* Tech writer fixes
  • Loading branch information
istvankovacs-bitrise authored Feb 15, 2021
1 parent 16fd468 commit f926cfd
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 2 deletions.
4 changes: 4 additions & 0 deletions main.go
Original file line number Diff line number Diff line change
Expand Up @@ -335,6 +335,10 @@ func findAPKsAndAABs(pths []string) (apks []string, aabs []string, others []stri
func deploy(clearedFilesToDeploy []string, config Config) (ArtifactURLCollection, error) {
apks, aabs, others := findAPKsAndAABs(clearedFilesToDeploy)

log.Warnf(`Universal APK generation is going to be DEPRECATED with the next major release! In case you build a bundle and you would like to
export a universal APK to distribute it for testing (by Public install page or Ship Add-on), please use the Export Universal APK Step instead!
You may find further information about the Step here (https://devcenter.bitrise.io/deploy/android-deploy/exporting-a-universal-apk-from-an-aab/).`)

if config.GenerateUniversalApkIfNone {
var err error
apks, _, err = ensureAABsHasUniversalAPKPair(aabs, apks, config.BundletoolVersion)
Expand Down
8 changes: 6 additions & 2 deletions step.yml
Original file line number Diff line number Diff line change
Expand Up @@ -225,11 +225,15 @@ inputs:
is_sensitive: true
- generate_universal_apk_if_none: "true"
opts:
title: "Force generate universal APK for AABs"
title: "Force generate universal APK for AABs (DEPRECATED)"
description: |
Universal APK generation is scheduled to be **DEPRECATED** in the next
major release. Please use the **Export Universal APK** Step instead! You
may find further information about the Step in our [Exporting a universal APK from an AAB](https://devcenter.bitrise.io/deploy/android-deploy/exporting-a-universal-apk-from-an-aab/) article.
When building an AAB artifact, check for a corresponding universal APK.
If none is found, generate the corresponding locally (debug) signed
universal APK for ease of debugging.
universal APK for easier debugging.
- debug_mode: "false"
opts:
category: Debug
Expand Down

0 comments on commit f926cfd

Please sign in to comment.