Improve account maintenance performance #803 #1085
Conversation
libraries/chain/db_balance.cpp
Outdated
| @@ -158,6 +160,10 @@ void database::deposit_cashback(const account_object& acct, share_type amount, b | |||
| { | |||
| _acct.cashback_vb = *new_vbid; | |||
| } ); | |||
| modify( acct.statistics( *this ), [&]( account_statistics_object& aso ) | |||
There was a problem hiding this comment.
Will remove the & here.
abitmore
force-pushed
the
803-maintenance-performance
branch
from
1f2c8ef to
8f08ec9
Compare
| if( bal_idx.begin() != bal_idx.end() ) | ||
| { | ||
| auto bal_itr = bal_idx.rbegin(); | ||
| while( bal_itr->maintenance_flag ) |
There was a problem hiding this comment.
Must check bal_itr != bal_idx.rend(), then you can remove enclosing if.
There was a problem hiding this comment.
You mean change it to while( bal_itr != bal_idx.rend() && bal_itr->maintenance_flag )? I think my implementation has better performance, since there is only one check outside the loop.
There was a problem hiding this comment.
Oh, now I see - if bal_idx is not empty() then bal_idx.rbegin() will always exist and the while loop ends when all entries with maintenance_flag have been handled. Ok.
|
Thank you @pmconrad. @jmjatlanta: do you want to take a look at this PR before merging? |
|
|
||
| auto& params = db().get_global_properties().parameters; | ||
| const auto& params = global_properties.parameters; |
There was a problem hiding this comment.
very minor: It looks like this is the only use of global_properties. Perhaps grab params instead of global_properties (line 191)?
There was a problem hiding this comment.
Oops, nevermind. I see its use further down.
…ormance Improve account maintenance performance bitshares#803
PR for #803.
All existing test cases are passing, not sure if we need additional test cases.
With this patch, on my test machine, time for replaying
27,000,000blocks (with onlywitnessplugin enabled) reduced from13,812 secondsto6,112 seconds(saved55%).Update: with the 3rd commit (skip the accounts who are not voting), replay time is reduced to
5,633 seconds(saved59%overall).Update: successfully synced the chain without issue.