Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cherry pick scanner and action cable work #3170

Merged
merged 14 commits into from
Jan 23, 2025
Merged

Cherry pick scanner and action cable work #3170

merged 14 commits into from
Jan 23, 2025

Conversation

sammo1235
Copy link
Contributor

📝 A short description of the changes

  • cherry picks both the action cable work and dbt-scanner stuff

:shipit: Deployment implications

  • needs the buckets in place on production as well as the ENV VARs to access them

✅ Checklist

  • Features that cannot go live are behind a feature flag/env var or specify deploy date and open PR as draft
  • I have checked that commit messages make sense and explain the reasoning for each change
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have squashed any unnecessary or part-finished commits

🖼️ Screenshots (if appropriate - no PII/Prod data):

matthewford and others added 14 commits January 23, 2025 13:57
@matthewford @sammo1235
Remove Vigilion code and references
d642d09 
Use Carrierwave for file uploads
Update to use DBT-Scanner via URL with credentials
Add specs for new functionality and update existing specs where appropriate
@phil-l-brockwell @sammo1235
Remove clean? ambiguity from FileUploader
a6483c2
@sammo1235
Create collaborator channels, stop editing unless editor, and switchi…
8de5591 
…ng forms behaviour

Implements two main behaviours using ActionCable:
1. If a second user has the same section of a form open, they cannot edit it. However if the first user closes their tab
or moves on to a different section then editing rights are released to the second user.
2. If user 1 opens a second tab of the same form, they cannot edit in the second tab. They are shown a message telling them
to close the tab and edit in the first tab.
@sammo1235
Remove all pusher references and dependencies
f9f2264
@sammo1235
Add specs for collaborators and general room channels
c3842ae
@sammo1235
Cleanup
c6c4078
@sammo1235
Store room members in cache as Array
da1b7af
@phil-l-brockwell @sammo1235
Prevent deprecation warning
b78952a
@phil-l-brockwell @sammo1235
Hash tab identifiers
4a56be9
@phil-l-brockwell @sammo1235
Store collaborators as hashes in CollaboratorsChannel
c09e0ba
@phil-l-brockwell @sammo1235
Use tab_ident in GeneralRoomChannel
2230ad1
@phil-l-brockwell @sammo1235
Fix ApplicationController#session_cookie
5aaf289
@phil-l-brockwell @sammo1235
Use CredentialsResolver.redis_uri for ActionCable redis connection
57fb439
@phil-l-brockwell @sammo1235
Use redis as cache_store in production
284c6da
@sammo1235 sammo1235 merged commit 76650b9 into production Jan 23, 2025
8 checks passed
@sammo1235 sammo1235 deleted the cherry-pick-scanner-and-action-cable-work branch January 23, 2025 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewford matthewford matthewford approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sammo1235 @matthewford @phil-l-brockwell