Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix setactiveslot by sending multiple patch chunks #513

Merged
merged 5 commits into from
Mar 6, 2024

Conversation

bongbui321
Copy link
Contributor

@bongbui321 bongbui321 commented Mar 6, 2024

this fixes: #511, #402 #472

Confirm changing to slot b:

system_a:            Offset 0x0000000002208000, Length 0x00000002e5510000, Flags 0x0000000000000000, UUID 8d40cb7a-57b6-f435-e760-33794bfc7669, Type 0x97d7b011, Active False
system_b:            Offset 0x00000002e7718000, Length 0x00000002e5510000, Flags 0x0004000000000000, UUID cdfddd29-279b-a4c1-39b0-11bf88149800, Type 0x77036cd4, Active True

Also, I changed it to setting every partition with ending _a or _b be set active or non active accordingly. the previous implementation just change one partition only and then return

Also, for setting unactive slot, I'm fairly new to this but we set the flags like this
flags &= ~(AB_PARTITION_ATTR_SLOT_ACTIVE << (AB_FLAG_OFFSET*8)), or like that in the PR

@bongbui321 bongbui321 changed the title Fix setactiveslot Fix setactiveslot by sending multiple patch chunks Mar 6, 2024
@bkerler bkerler merged commit 3bfb87f into bkerler:master Mar 6, 2024
1 check passed
@bkerler
Copy link
Owner

bkerler commented Mar 6, 2024

Thanks :)

@bongbui321 bongbui321 deleted the fix_setactiveslot branch March 6, 2024 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

setactiveslot: batch size too large 128
2 participants