454 reorganize pipeline decision treepy script #549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…454-reorganize-pipeline_decision_treepy-script
dsclassen
requested changes
Jan 13, 2025
scripts/pipeline_decision_tree.py
Outdated
Comment on lines
149
to
151
| multi_states_file = multi_state_models[cs_models.index(best_cs)] | ||
| multi_states_num_i = multi_states_file.find("multi_state_model_") | ||
| multi_states_num = multi_states_file[multi_states_num_i + 18] |
There was a problem hiding this comment.
This function should return an index only.
| @@ -629,7 +609,7 @@ def handle_poor_fit( | |||
| if second_highest_chi_square_flag == "mid_q_err": | |||
| feedback += ( | |||
| " The movement of flexible regions in the model also do not seem to " | |||
| "improve the fitting." | |||
| "improve the fit." | |||
refactored best_chi_square_i function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added some test data sets and made some changes to the decision tree, along with some reorganizations.
The most notable change is the decision tree is the change to decide the "best chi square" from the ensemble states. Now, if will select the largest chi2 value that is < 2, or the smallest chi2 value if they are all >2
First request to pull to main... trying to see how this works too