fix: update @typescript-eslint/eslint-plugin to use deprecated rule (…

…#2756) * fix: update `@typescript-eslint/eslint-plugin` to use deprecated rule * Restore NX package. Update NX. Update rules. * Update lint rules and address new issues. * Formatting. Dependency bumps. * Fix tests. Simplify changes. * Fix integration test. * Fix integration build. * Fix storybook, update e2e-schematics * Update package-lock * Update snapshot * Revert to interface rather than switching to type alias
blackbaud · Sep 18, 2024 · a4ab15a · a4ab15a
1 parent e1fd53c
commit a4ab15a
Show file tree

Hide file tree

Showing 104 changed files with 3,598 additions and 3,264 deletions.
diff --git a/.eslintrc-overrides.json b/.eslintrc-overrides.json
@@ -3,7 +3,6 @@
     {
       "files": ["*.ts"],
       "rules": {
-        "@typescript-eslint/ban-types": "warn",
         "@typescript-eslint/no-empty-function": "warn",
         "@typescript-eslint/no-explicit-any": "warn",
         "@typescript-eslint/no-non-null-assertion": "warn",

diff --git a/.eslintrc.json b/.eslintrc.json
@@ -30,18 +30,12 @@
     {
       "files": ["*.ts", "*.tsx"],
       "extends": ["plugin:@nx/typescript", "prettier"],
-      "rules": {
-        "@typescript-eslint/no-extra-semi": "error",
-        "no-extra-semi": "off"
-      }
+      "rules": {}
     },
     {
       "files": ["*.js", "*.jsx"],
       "extends": ["plugin:@nx/javascript", "prettier"],
-      "rules": {
-        "@typescript-eslint/no-extra-semi": "error",
-        "no-extra-semi": "off"
-      }
+      "rules": {}
     },
     {
       "files": ["*.stories.@(ts|tsx|js|jsx|mjs|cjs)"],

diff --git a/apps/code-examples/project.json b/apps/code-examples/project.json
@@ -119,5 +119,6 @@
       }
     }
   },
+  "implicitDependencies": ["eslint-config"],
   "tags": []
 }
diff --git a/...mples/src/app/code-examples/angular-tree-component/angular-tree/basic/demo.component.html b/...mples/src/app/code-examples/angular-tree-component/angular-tree/basic/demo.component.html
@@ -1,10 +1,10 @@
 <sky-angular-tree-wrapper>
   <tree-root #tree [nodes]="nodes">
     <ng-template
+      #treeNodeFullTemplate
       let-index="index"
       let-node
       let-templates="templates"
-      #treeNodeFullTemplate
     >
       <sky-angular-tree-node
         [helpPopoverContent]="node.data.helpPopoverContent"

diff --git a/apps/code-examples/src/app/code-examples/lookup/autocomplete/advanced/demo.component.html b/apps/code-examples/src/app/code-examples/lookup/autocomplete/advanced/demo.component.html
@@ -35,7 +35,7 @@
   <pre>{{ formGroup.value | json }}</pre>
 </form>
 
-<ng-template let-item="item" #planetSearchResultTemplate>
+<ng-template #planetSearchResultTemplate let-item="item">
   <strong>
     {{ item.name }}
   </strong>

diff --git a/...code-examples/src/app/code-examples/lookup/autocomplete/custom-search/demo.component.html b/...code-examples/src/app/code-examples/lookup/autocomplete/custom-search/demo.component.html
@@ -26,7 +26,7 @@
   <pre>{{ formGroup.value | json }}</pre>
 </form>
 
-<ng-template let-item="item" #oceanSearchResultTemplate>
+<ng-template #oceanSearchResultTemplate let-item="item">
   <sky-icon icon="long-arrow-right" />
   {{ item.title }} &bull; ID {{ item.id }}
 </ng-template>
diff --git a/apps/e2e/help-inline-storybook/.storybook/tsconfig.json b/apps/e2e/help-inline-storybook/.storybook/tsconfig.json
@@ -9,9 +9,6 @@
   "include": [
     "../src/**/*.stories.ts",
     "../src/**/*.stories.js",
-    "../src/**/*.stories.jsx",
-    "../src/**/*.stories.tsx",
-    "../src/**/*.stories.mdx",
     "*.js",
     "*.ts",
     "./*"

diff --git a/apps/e2e/lists-storybook/src/test-setup.ts b/apps/e2e/lists-storybook/src/test-setup.ts
@@ -1,4 +1,4 @@
 import 'jest-preset-angular/setup-jest';
+import 'resize-observer-polyfill';
 
 // jsdom (used by Jest) doesn't natively support ResizeObserver, so use a polyfill.
-global.ResizeObserver = require('resize-observer-polyfill');
diff --git a/apps/integration/src/app/integrations/field-heights/field-heights.component.ts b/apps/integration/src/app/integrations/field-heights/field-heights.component.ts
@@ -130,7 +130,9 @@ export class FieldHeightsComponent implements AfterViewInit, OnDestroy {
               console.log(`Doesn't match .height-measure`, heightElement);
             }
           });
-          this.ready.getValue() || this.ready.next(true);
+          if (!this.ready.getValue()) {
+            this.ready.next(true);
+          }
         }),
     );
   }

diff --git a/apps/integration/src/app/integrations/lookup-in-modal/lookup-in-modal.component.ts b/apps/integration/src/app/integrations/lookup-in-modal/lookup-in-modal.component.ts
@@ -1,7 +1,7 @@
 import { DOCUMENT } from '@angular/common';
 import { Component, OnDestroy, OnInit, inject } from '@angular/core';
 import { SkyModalService } from '@skyux/modals';
-import { FontLoadingService } from '@skyux/storybook';
+import { FontLoadingService } from '@skyux/storybook/font-loading';
 
 import { delay } from 'rxjs';
 

diff --git a/...on/src/app/integrations/modal-viewkept-toolbars/modal-viewkept-toolbars.component.spec.ts b/...on/src/app/integrations/modal-viewkept-toolbars/modal-viewkept-toolbars.component.spec.ts
@@ -48,7 +48,6 @@ describe('Modals with viewkept toolbars', () => {
 
   function openModal(): void {
     getModalTrigger()?.click();
-    fixture.detectChanges;
   }
 
   async function scrollContentDown(): Promise<void> {

diff --git a/...gration/src/app/integrations/modal-viewkept-toolbars/modal-viewkept-toolbars.component.ts b/...gration/src/app/integrations/modal-viewkept-toolbars/modal-viewkept-toolbars.component.ts
@@ -1,6 +1,6 @@
 import { ChangeDetectionStrategy, Component, inject } from '@angular/core';
 import { SkyModalService } from '@skyux/modals';
-import { FontLoadingService } from '@skyux/storybook';
+import { FontLoadingService } from '@skyux/storybook/font-loading';
 
 import { delay } from 'rxjs';
 

diff --git a/apps/integration/src/app/integrations/modal-wait/modal-wait.component.spec.ts b/apps/integration/src/app/integrations/modal-wait/modal-wait.component.spec.ts
@@ -57,7 +57,6 @@ describe('Modals with wait', () => {
 
   function openModal(): void {
     getModalTrigger()?.click();
-    fixture.detectChanges;
   }
 
   let fixture: ComponentFixture<ModalWaitComponent>;

diff --git a/libs/components/a11y/package.json b/libs/components/a11y/package.json
@@ -16,8 +16,8 @@
   },
   "homepage": "https://github.com/blackbaud/skyux#readme",
   "peerDependencies": {
-    "@angular/common": "^18.2.3",
-    "@angular/core": "^18.2.3",
+    "@angular/common": "^18.2.5",
+    "@angular/core": "^18.2.5",
     "@skyux/core": "0.0.0-PLACEHOLDER",
     "@skyux/i18n": "0.0.0-PLACEHOLDER"
   },

diff --git a/libs/components/action-bars/package.json b/libs/components/action-bars/package.json
@@ -16,10 +16,10 @@
   },
   "homepage": "https://github.com/blackbaud/skyux#readme",
   "peerDependencies": {
-    "@angular/animations": "^18.2.3",
-    "@angular/common": "^18.2.3",
-    "@angular/core": "^18.2.3",
-    "@angular/platform-browser": "^18.2.3",
+    "@angular/animations": "^18.2.5",
+    "@angular/common": "^18.2.5",
+    "@angular/core": "^18.2.5",
+    "@angular/platform-browser": "^18.2.5",
     "@skyux-sdk/testing": "0.0.0-PLACEHOLDER",
     "@skyux/animations": "0.0.0-PLACEHOLDER",
     "@skyux/core": "0.0.0-PLACEHOLDER",

diff --git a/libs/components/ag-grid/package.json b/libs/components/ag-grid/package.json
@@ -21,9 +21,9 @@
     }
   },
   "peerDependencies": {
-    "@angular/common": "^18.2.3",
-    "@angular/core": "^18.2.3",
-    "@angular/forms": "^18.2.3",
+    "@angular/common": "^18.2.5",
+    "@angular/core": "^18.2.5",
+    "@angular/forms": "^18.2.5",
     "@skyux/autonumeric": "0.0.0-PLACEHOLDER",
     "@skyux/core": "0.0.0-PLACEHOLDER",
     "@skyux/data-manager": "0.0.0-PLACEHOLDER",

diff --git a/...components/ag-grid/src/lib/modules/ag-grid/ag-grid-data-manager-adapter.directive.spec.ts b/...components/ag-grid/src/lib/modules/ag-grid/ag-grid-data-manager-adapter.directive.spec.ts
@@ -367,11 +367,11 @@ describe('SkyAgGridDataManagerAdapterDirective', () => {
     } as ColumnResizedEvent;
 
     const viewState = dataState.views[0];
-    (viewState.columnWidths = {
+    viewState.columnWidths = {
       xs: { name: 180, target: 220 },
       sm: { name: 100, target: 400 },
-    }),
-      agGridComponent.columnResized.emit(columnResized);
+    };
+    agGridComponent.columnResized.emit(columnResized);
     agGridDataManagerFixture.detectChanges();
     await agGridDataManagerFixture.whenStable();
 
@@ -403,11 +403,11 @@ describe('SkyAgGridDataManagerAdapterDirective', () => {
     } as ColumnResizedEvent;
 
     const viewState = dataState.views[0];
-    (viewState.columnWidths = {
+    viewState.columnWidths = {
       xs: { name: 100, target: 220 },
       sm: { name: 300, target: 400 },
-    }),
-      agGridComponent.columnResized.emit(columnResized);
+    };
+    agGridComponent.columnResized.emit(columnResized);
     agGridDataManagerFixture.detectChanges();
     await agGridDataManagerFixture.whenStable();
 

diff --git a/libs/components/ag-grid/src/lib/modules/ag-grid/ag-grid-row-delete.component.ts b/libs/components/ag-grid/src/lib/modules/ag-grid/ag-grid-row-delete.component.ts
@@ -18,12 +18,12 @@ import { SkyInlineDeleteModule } from '@skyux/layout';
   selector: 'sky-ag-grid-row-delete',
   template: `
     <ng-template
+      #inlineDeleteTemplateRef
       let-row
       let-tableWidth="tableWidth()"
       let-getRowDeleteItem="getRowDeleteItem"
       let-cancelRowDelete="cancelRowDelete"
       let-confirmRowDelete="confirmRowDelete"
-      #inlineDeleteTemplateRef
     >
       <div
         #inlineDeleteRef

diff --git a/libs/components/ag-grid/src/lib/modules/ag-grid/ag-grid-wrapper.component.spec.ts b/libs/components/ag-grid/src/lib/modules/ag-grid/ag-grid-wrapper.component.spec.ts
@@ -412,7 +412,6 @@ describe('SkyAgGridWrapperComponent', () => {
     }
 
     it('should not move focus when tab is pressed but cells are being edited', () => {
-      agGrid.api.stopEditing as jasmine.Spy;
       fireKeyupEscape();
       expect(agGrid.api.stopEditing).toHaveBeenCalled();
     });

diff --git a/libs/components/ag-grid/src/lib/modules/ag-grid/ag-grid-wrapper.component.ts b/libs/components/ag-grid/src/lib/modules/ag-grid/ag-grid-wrapper.component.ts
@@ -299,6 +299,7 @@ export class SkyAgGridWrapperComponent
     }
   }
 
+  // eslint-disable-next-line complexity
   public onAnchorFocus(event: FocusEvent): void {
     const relatedTarget = event.relatedTarget as HTMLElement | undefined;
     const previousWasGrid =

diff --git a/libs/components/ag-grid/src/lib/modules/ag-grid/ag-grid.service.spec.ts b/libs/components/ag-grid/src/lib/modules/ag-grid/ag-grid.service.spec.ts
@@ -225,7 +225,7 @@ describe('SkyAgGridService', () => {
         'function',
       );
       expect(
-        (modernThemeGridOptions.icons?.['sortDescending'] as Function)(),
+        (modernThemeGridOptions.icons?.['sortDescending'] as () => string)(),
       ).toBe(`<i aria-hidden="true" class="sky-i-chevron-down"></i>`);
     });
 
@@ -636,7 +636,7 @@ describe('SkyAgGridService', () => {
   });
 
   describe('getDefaultGridOptions getEditableFn', () => {
-    let cellClassRuleEditableFunction: Function;
+    let cellClassRuleEditableFunction: (params?: any) => boolean;
     let cellClassParams: CellClassParams;
 
     beforeEach(() => {

diff --git a/libs/components/ag-grid/src/lib/modules/ag-grid/types/autocomplete-properties.ts b/libs/components/ag-grid/src/lib/modules/ag-grid/types/autocomplete-properties.ts
@@ -20,6 +20,6 @@ export interface SkyAgGridAutocompleteProperties {
 /**
  * @deprecated Use SkyAgGridAutocompleteProperties instead.
  */
-// eslint-disable-next-line @typescript-eslint/no-empty-interface
+// eslint-disable-next-line
 export interface SkyAutocompleteProperties
   extends SkyAgGridAutocompleteProperties {}
diff --git a/libs/components/ag-grid/src/lib/modules/ag-grid/types/datepicker-properties.ts b/libs/components/ag-grid/src/lib/modules/ag-grid/types/datepicker-properties.ts
@@ -10,6 +10,6 @@ export interface SkyAgGridDatepickerProperties {
 /**
  * @deprecated Use SkyAgGridDatepickerProperties instead.
  */
-// eslint-disable-next-line @typescript-eslint/no-empty-interface
+// eslint-disable-next-line
 export interface SkyDatepickerProperties
   extends SkyAgGridDatepickerProperties {}
diff --git a/libs/components/angular-tree-component/package.json b/libs/components/angular-tree-component/package.json
@@ -16,8 +16,8 @@
   },
   "homepage": "https://github.com/blackbaud/skyux#readme",
   "peerDependencies": {
-    "@angular/common": "^18.2.3",
-    "@angular/core": "^18.2.3",
+    "@angular/common": "^18.2.5",
+    "@angular/core": "^18.2.5",
     "@blackbaud/angular-tree-component": "^1.0.0",
     "@skyux/core": "0.0.0-PLACEHOLDER",
     "@skyux/forms": "0.0.0-PLACEHOLDER",

diff --git a/libs/components/animations/package.json b/libs/components/animations/package.json
@@ -16,9 +16,9 @@
   },
   "homepage": "https://github.com/blackbaud/skyux#readme",
   "peerDependencies": {
-    "@angular/animations": "^18.2.3",
-    "@angular/common": "^18.2.3",
-    "@angular/core": "^18.2.3"
+    "@angular/animations": "^18.2.5",
+    "@angular/common": "^18.2.5",
+    "@angular/core": "^18.2.5"
   },
   "dependencies": {
     "tslib": "^2.6.3"

diff --git a/libs/components/assets/package.json b/libs/components/assets/package.json
@@ -16,8 +16,8 @@
   },
   "homepage": "https://github.com/blackbaud/skyux#readme",
   "peerDependencies": {
-    "@angular/common": "^18.2.3",
-    "@angular/core": "^18.2.3"
+    "@angular/common": "^18.2.5",
+    "@angular/core": "^18.2.5"
   },
   "dependencies": {
     "tslib": "^2.6.3"

diff --git a/libs/components/autonumeric/package.json b/libs/components/autonumeric/package.json
@@ -16,9 +16,9 @@
   },
   "homepage": "https://github.com/blackbaud/skyux#readme",
   "peerDependencies": {
-    "@angular/common": "^18.2.3",
-    "@angular/core": "^18.2.3",
-    "@angular/forms": "^18.2.3",
+    "@angular/common": "^18.2.5",
+    "@angular/core": "^18.2.5",
+    "@angular/forms": "^18.2.5",
     "autonumeric": "^4.10.5"
   },
   "dependencies": {

diff --git a/libs/components/avatar/package.json b/libs/components/avatar/package.json
@@ -16,9 +16,9 @@
   },
   "homepage": "https://github.com/blackbaud/skyux#readme",
   "peerDependencies": {
-    "@angular/common": "^18.2.3",
-    "@angular/core": "^18.2.3",
-    "@angular/platform-browser": "^18.2.3",
+    "@angular/common": "^18.2.5",
+    "@angular/core": "^18.2.5",
+    "@angular/platform-browser": "^18.2.5",
     "@skyux-sdk/testing": "0.0.0-PLACEHOLDER",
     "@skyux/core": "0.0.0-PLACEHOLDER",
     "@skyux/errors": "0.0.0-PLACEHOLDER",

diff --git a/libs/components/colorpicker/package.json b/libs/components/colorpicker/package.json
@@ -16,11 +16,11 @@
   },
   "homepage": "https://github.com/blackbaud/skyux#readme",
   "peerDependencies": {
-    "@angular/cdk": "^18.2.3",
-    "@angular/common": "^18.2.3",
-    "@angular/core": "^18.2.3",
-    "@angular/forms": "^18.2.3",
-    "@angular/platform-browser": "^18.2.3",
+    "@angular/cdk": "^18.2.4",
+    "@angular/common": "^18.2.5",
+    "@angular/core": "^18.2.5",
+    "@angular/forms": "^18.2.5",
+    "@angular/platform-browser": "^18.2.5",
     "@skyux-sdk/testing": "0.0.0-PLACEHOLDER",
     "@skyux/core": "0.0.0-PLACEHOLDER",
     "@skyux/forms": "0.0.0-PLACEHOLDER",

diff --git a/libs/components/config/package.json b/libs/components/config/package.json
@@ -16,8 +16,8 @@
   },
   "homepage": "https://github.com/blackbaud/skyux#readme",
   "peerDependencies": {
-    "@angular/common": "^18.2.3",
-    "@angular/core": "^18.2.3"
+    "@angular/common": "^18.2.5",
+    "@angular/core": "^18.2.5"
   },
   "dependencies": {
     "tslib": "^2.6.3"

diff --git a/libs/components/config/src/lib/config.ts b/libs/components/config/src/lib/config.ts
@@ -57,7 +57,7 @@ export interface RuntimeConfig {
   includeRouteModule: boolean;
   pactConfig?: SkyuxPactConfig;
   params: SkyAppRuntimeConfigParams;
-  routes?: Object[]; // Dynamically added in sky-pages-module-generator.js
+  routes?: object[]; // Dynamically added in sky-pages-module-generator.js
   routesPattern: string;
   runtimeAlias: string;
   spaPathAlias: string;
@@ -81,7 +81,7 @@ export interface SkyuxConfigAppTheming {
 
 export interface SkyuxConfigApp {
   base?: string;
-  externals?: Object;
+  externals?: object;
   port?: string;
   styles?: string[];
   theming?: SkyuxConfigAppTheming;

diff --git a/libs/components/core/package.json b/libs/components/core/package.json
@@ -16,11 +16,11 @@
   },
   "homepage": "https://github.com/blackbaud/skyux#readme",
   "peerDependencies": {
-    "@angular/cdk": "^18.2.3",
-    "@angular/common": "^18.2.3",
-    "@angular/core": "^18.2.3",
-    "@angular/platform-browser": "^18.2.3",
-    "@angular/router": "^18.2.3",
+    "@angular/cdk": "^18.2.4",
+    "@angular/common": "^18.2.5",
+    "@angular/core": "^18.2.5",
+    "@angular/platform-browser": "^18.2.5",
+    "@angular/router": "^18.2.5",
     "@skyux/i18n": "0.0.0-PLACEHOLDER"
   },
   "dependencies": {

diff --git a/libs/components/core/src/lib/modules/overlay/fixtures/overlay.component.fixture.html b/libs/components/core/src/lib/modules/overlay/fixtures/overlay.component.fixture.html
@@ -1,3 +1,3 @@
-<ng-template let-item #myTemplate
+<ng-template #myTemplate let-item
   >Templated content ID: {{ item.id }}</ng-template
 >
-Original file line number
+Diff line change
@@ Expand Up / @@ -119,5 +119,6 @@ @@
           }
         }
       },
+      "implicitDependencies": ["eslint-config"],
       "tags": []
     }