Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(components/popovers): screen readers can navigate to popover contents #2672

Closed
wants to merge 19 commits into from

Conversation

Blackbaud-SteveBrush
Copy link
Member

@Blackbaud-SteveBrush Blackbaud-SteveBrush commented Aug 30, 2024

AB#3027447

The resulting HTML will look like:

<button type="button" aria-controls="pointer-1" aria-expanded="true"></button>
<span id="pointer-1" aria-owns="popover-1"></span>

...

<sky-popover-content id="popover-1"></sky-popover-content>

Copy link

nx-cloud bot commented Aug 30, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 4b01814. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 59 targets

Sent with 💌 from NxCloud.

@Blackbaud-SteveBrush Blackbaud-SteveBrush added the risk level (author): 2 This change has a slight chance of introducing a bug label Aug 30, 2024
@Blackbaud-SteveBrush Blackbaud-SteveBrush marked this pull request as draft September 3, 2024 15:46
@Blackbaud-SteveBrush Blackbaud-SteveBrush marked this pull request as ready for review September 4, 2024 18:20
@Blackbaud-SteveBrush Blackbaud-SteveBrush enabled auto-merge (squash) September 6, 2024 14:26
@Blackbaud-SteveBrush Blackbaud-SteveBrush marked this pull request as draft September 10, 2024 14:59
auto-merge was automatically disabled September 10, 2024 14:59

Pull request was converted to draft

@Blackbaud-SteveBrush
Copy link
Member Author

Closing in favor of #2729

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
risk level (author): 2 This change has a slight chance of introducing a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants