Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(components/layout): use standalone components and signal inputs for fluid grid #3031

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

Blackbaud-SteveBrush
Copy link
Member

No description provided.

Copy link

nx-cloud bot commented Jan 15, 2025

View your CI Pipeline Execution ↗ for commit 4a291cc.

Command Status Duration Result
nx affected --target lint test posttest --confi... ✅ Succeeded 3m 13s View ↗
nx affected --target build lint test posttest -... ✅ Succeeded 4m 6s View ↗

☁️ Nx Cloud last updated this comment at 2025-01-15 16:49:44 UTC

@@ -26,6 +26,10 @@
}
}

sky-column {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm removing all the extraneous div elements from these components and using the host selectors as the wrappers instead.

<sky-column [screenSmall]="1"> [screenSmall]="1" </sky-column>
<sky-column [screenSmall]="1"> [screenSmall]="1" </sky-column>
<sky-column [screenSmall]="1"> [screenSmall]="1" </sky-column>
<sky-column screenSmall="1"> screenSmall="1" </sky-column>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using numberAttribute transform on these inputs creates a simpler API.

@Blackbaud-SteveBrush Blackbaud-SteveBrush added the risk level (author): 3 This change has a moderate chance of introducing a bug label Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
risk level (author): 3 This change has a moderate chance of introducing a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants