-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(components/layout): use standalone components and signal inputs for fluid grid #3031
base: main
Are you sure you want to change the base?
Conversation
View your CI Pipeline Execution ↗ for commit 4a291cc.
☁️ Nx Cloud last updated this comment at |
@@ -26,6 +26,10 @@ | |||
} | |||
} | |||
|
|||
sky-column { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm removing all the extraneous div
elements from these components and using the host selectors as the wrappers instead.
<sky-column [screenSmall]="1"> [screenSmall]="1" </sky-column> | ||
<sky-column [screenSmall]="1"> [screenSmall]="1" </sky-column> | ||
<sky-column [screenSmall]="1"> [screenSmall]="1" </sky-column> | ||
<sky-column screenSmall="1"> screenSmall="1" </sky-column> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using numberAttribute
transform on these inputs creates a simpler API.
No description provided.